Adjust Optimism (Mainnet) TotalDifficulty calculation
#7647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlautarom1
requested review from
MarekM25,
LukaszRozmej,
jmederosalvarado,
flcl42 and
asdacap
benaadams
approved these changes
Oct 23, 2024
src/Nethermind/Nethermind.Optimism/OptimismSynchronizerModule.cs
Outdated
Show resolved
Hide resolved
asdacap
reviewed
Oct 23, 2024
src/Nethermind/Nethermind.Optimism/OptimismSynchronizerModule.cs
Outdated
Show resolved
Hide resolved
asdacap
reviewed
Oct 23, 2024
| { | ||
| base.Load(builder); | ||
|
|
||
| if (provider.ChainId == OptimismMainnetChainId) |
There was a problem hiding this comment.
This check is not needed. Just have one OptimismSynchronizerModule for just optimism configuration, the register it later after MergeSynchronizerModule.
There was a problem hiding this comment.
The check is actually needed since we want to use a particular difficulty calculation strategy in Optimism Mainnet and not in, for example, Optimism Sepolia.
asdacap
approved these changes
Oct 24, 2024
kamilchodola
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7626
Changes
TotalDifficultyat the Bedrock block in OptimismTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Tested by running a node using the
op-mainnetconfiguration. AllOld Headerswere downloaded without any issues and properTotalDifficultyis always calculated correctly.Documentation
Requires documentation update
This change should be internal so no need to update docs.
Requires explanation in Release Notes
Remarks
Some changes required adjusting the DI modules specific for Optimism. It was not as straightforward as I would have expected it to be.